Improve coverage

src/file_utils.cpp

@@ -37,6 +37,7 @@ bool get_file_size(const char *name, size_t &size) {
         if (errno != ENOENT) {
             log_write(LOG_LEVEL_ERR_ERRNO, "stat call failed for file %s", name);
         }
+        size = 0;
         return false;
     }
     size = structstat.st_size;

tests/CMakeLists.txt

@@ -6,18 +6,18 @@ find_package(ZLIB REQUIRED)
 
 add_executable(${TARGET}
     Convert.cpp
+    Dictionary_test.cpp
+    DumpUtilsTest.cpp
+    FileUtils_Test.cpp
     Log_test.cpp
-    ShmBufferEx_Test.cpp
+    ShmBase_Test.cpp
     ShmBuffer_Test.cpp
+    ShmBufferEx_Test.cpp
+    SysInfo.cpp
     TestCounter.cpp
-    TestCountersInit.cpp
     TestCounters.cpp
-    ShmBase_Test.cpp
-    FileUtils_Test.cpp
-    Dictionary_test.cpp
+    TestCountersInit.cpp
     TestTimeUtils.cpp
-    DumpUtilsTest.cpp
-    SysInfo.cpp
     TestUptime.cpp
 )
 

tests/FileUtils_Test.cpp

@@ -17,12 +17,45 @@ TEST(FileUtils, FileNotExists) {
 
 
 TEST(FileUtils, FileNotExistsInvalid) {
-    remove(TEST_FILE);
     EXPECT_FALSE(is_file_exists(""));
     EXPECT_FALSE(is_file_exists(TEST_FILE_INVALID));
     EXPECT_FALSE(is_file_exists("../../../../../../../../../some_file.txt"));
 }
 
+TEST(FileUtils, FileSize) {
+    FILE* fp = fopen(TEST_FILE, "ab+");
+    fclose(fp);
+    size_t size=123;
+    EXPECT_TRUE(get_file_size(TEST_FILE, size));
+    EXPECT_EQ(0, size);
+    fp = fopen(TEST_FILE, "ab+");
+    fwrite("0123456789", 1, 10, fp);
+    fclose(fp);
+    EXPECT_TRUE(get_file_size(TEST_FILE, size));
+    EXPECT_EQ(10, size);
+}
+
+TEST(FileUtils, FileSizeNotExists) {
+    remove(TEST_FILE);
+    size_t size = 123;
+    EXPECT_FALSE(get_file_size(TEST_FILE, size));
+    EXPECT_EQ(0, size);
+}
+
+TEST(FileUtils, FileSizeInvalid) {
+    size_t size = 123;
+    EXPECT_FALSE(get_file_size("", size));
+    EXPECT_EQ(0, size);
+
+    size = 123;
+    EXPECT_FALSE(get_file_size(TEST_FILE_INVALID, size));
+    EXPECT_EQ(0, size);
+
+    size = 123;
+    EXPECT_FALSE(get_file_size("../../../../../../../../../some_file.txt", size));
+    EXPECT_EQ(0, size);
+}
+
 TEST(FileUtils, DirExists) {
     EXPECT_TRUE(is_dir_exists("."));
     EXPECT_TRUE(is_dir_exists("/"));