test: add unit tests for terminal ExecCommand detach behavior

[mason5052]

Description of the Change

Problem

The terminal ExecCommand function (408 lines) had zero test coverage. The detached execution path -- recently fixed for context isolation (#176, #179) -- particularly needed validation.

Solution

Add mock infrastructure and 4 test cases for terminal command execution:

Mock infrastructure:

• mockDockerClient: Implements full docker.DockerClient interface with configurable responses, timing delays, and error injection. Uses net.Pipe() for realistic streaming output simulation.
• mockTermLogProvider: Implements TermLogProvider interface (no-op for tests).
• Both include compile-time interface checks (var _ Interface = (*mock)(nil)).

Test cases:

• TestExecCommandDetachReturnsQuickly: Verifies detach=true returns "Command started in background" within ~500ms even when the command takes 2s+
• TestExecCommandDetachQuickCompletion: Verifies detach=true returns actual output when command finishes before the quick check timeout
• TestExecCommandNonDetachWaitsForCompletion: Verifies detach=false blocks until command completes and returns full output
• TestExecCommandContainerNotRunning: Verifies proper error handling when container is not running

The mock infrastructure is reusable for future terminal.go test expansion (ReadFile, WriteFile, etc.).

Related to #176
Adds test coverage for #179

Type of Change

• Tests (adding or updating tests)

Areas Affected

• Core Services (Backend API)

Testing and Verification

Test Configuration

• PentAGI Version: master
• Go Version: 1.24

Test Steps

1. go test ./pkg/tools/ -run "TestExecCommand" -v -- all 4 tests pass
2. go vet ./pkg/tools/ -- no warnings
3. Pre-existing TestSploitusParseExploitsResponse/nginx failure is unrelated (Windows Defender file access issue on test data)

Security Considerations

No security impact. Test-only change. Mock infrastructure does not interact with real Docker.

Checklist

• My code follows the project's coding standards
• All new and existing tests pass
• I have run go fmt and go vet
• Security implications considered
• Changes are backward compatible

[Copilot]

Pull request overview

Adds unit test coverage for the terminal.ExecCommand detach and non-detach execution paths, using lightweight Docker/terminal log mocks to simulate exec output and timing behavior.

Changes:

• Introduces mockDockerClient implementing docker.DockerClient with configurable attach delays and streamed output via net.Pipe().
• Adds mockTermLogProvider implementing TermLogProvider for no-op logging in tests.
• Adds four ExecCommand unit tests covering detach quick-return, detach quick-completion, non-detach completion, and “container not running” error behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

TestExecCommandDetachReturnsQuickly claims detach should return within defaultQuickCheckTimeout (500ms), but the assertion only checks < 2s, which can let regressions through (e.g., returning after 1–1.5s would still pass). Consider asserting against defaultQuickCheckTimeout (plus a small scheduling margin) so the test actually enforces the intended contract.

Suggested change

	assert.Less(t, elapsed, 2*time.Second, "detach should return within ~500ms, not wait for command")
	assert.Less(t, elapsed, 750*time.Millisecond, "detach should return within defaultQuickCheckTimeout (~500ms) plus small margin, not wait for command")