T6718: use the vyconf daemon for validation of set commands#21
T6718: use the vyconf daemon for validation of set commands#21jestabro merged 5 commits intovyos-legacy:currentfrom
Conversation
Links added in earlier commit, but one instance missed. Cf. yallop/ocaml-ctypes#651
755c3c1 to
3394642
Compare
3394642 to
ff23789
Compare
ff23789 to
bd71aa6
Compare
dmbaturin
left a comment
There was a problem hiding this comment.
This will certainly work, but I wonder if we should package vyconf and its tools separately at a later point.
|
Now that we have the whole of vyconf available, I expect we will want to refactor the distinction vyconf <-> vyos1x-config as well as packaging. |
|
This will benefit from a single commit PR for vyos-1x before merging, to make for a smooth transition (as ctypes do not, as far as I know, have a notion of optional argument, we must introduce a keyword argument with default for the python wrapper |
|
After this merge, the update to the Docker file to reflect new commit hash will need to be accompanied by: |
Change Summary
This PR has been updated with appropriate commit hashes in build.sh, following merge of
vyos/vyos1x-config#31
vyos/vyconf#11
and is ready for review.
It is required by the corresponding PR for vyos-1x.
Types of changes
Related Task(s)
Related PR(s)
vyos/vyos1x-config#31
vyos/vyconf#11
Proposed changes
How to test
Checklist: