vyconf: T6718: add keyword default for change in libvyosconfig binding#4226
Merged
dmbaturin merged 1 commit intovyos:currentfrom Dec 6, 2024
Merged
vyconf: T6718: add keyword default for change in libvyosconfig binding#4226dmbaturin merged 1 commit intovyos:currentfrom
dmbaturin merged 1 commit intovyos:currentfrom
Conversation
Adjust signature of reference_tree_to_json for change in the ctypes binding.
|
👍 |
10 tasks
Contributor
Author
|
N.B. this will not build until the commit hash for libvyosconfig is updated in |
11 tasks
Contributor
Author
|
Open for review, but as noted above, this will not build, nor should be merged, until merge of vyos/vyos-build#824 |
sarthurdev
approved these changes
Dec 6, 2024
dmbaturin
approved these changes
Dec 6, 2024
|
CI integration 👍 passed! Details
|
This was referenced Dec 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Adjust signature of
reference_tree_to_jsonfor change in the ctypes binding.Split off commit from #4176 to solve a chicken-egg problem with the change in signature of
reference_tree_to_jsonafter merge of vyos-legacy/libvyosconfig#21 and resulting update in vyos/vyos-build#824Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: