Skip to content

vyconf: T6718: add keyword default for change in libvyosconfig binding#4226

Merged
dmbaturin merged 1 commit intovyos:currentfrom
jestabro:opt-arg-reference-tree
Dec 6, 2024
Merged

vyconf: T6718: add keyword default for change in libvyosconfig binding#4226
dmbaturin merged 1 commit intovyos:currentfrom
jestabro:opt-arg-reference-tree

Conversation

@jestabro
Copy link
Contributor

@jestabro jestabro commented Dec 6, 2024

Change Summary

Adjust signature of reference_tree_to_json for change in the ctypes binding.

Split off commit from #4176 to solve a chicken-egg problem with the change in signature of reference_tree_to_json after merge of vyos-legacy/libvyosconfig#21 and resulting update in vyos/vyos-build#824

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Adjust signature of reference_tree_to_json for change in the ctypes
binding.
@jestabro jestabro self-assigned this Dec 6, 2024
@github-actions
Copy link

github-actions bot commented Dec 6, 2024

👍
No issues in PR Title / Commit Title

@jestabro
Copy link
Contributor Author

jestabro commented Dec 6, 2024

N.B. this will not build until the commit hash for libvyosconfig is updated in
vyos/vyos-build#824
and that PR merged, at which point it will be required for successful build.

@jestabro
Copy link
Contributor Author

jestabro commented Dec 6, 2024

Open for review, but as noted above, this will not build, nor should be merged, until merge of vyos/vyos-build#824

@jestabro jestabro marked this pull request as ready for review December 6, 2024 15:59
@jestabro jestabro requested a review from a team as a code owner December 6, 2024 15:59
@dmbaturin dmbaturin merged commit b56673c into vyos:current Dec 6, 2024
@github-actions
Copy link

github-actions bot commented Dec 6, 2024

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants