Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback-soft: T6384: tell the user to compare or commit #3501

Merged
merged 1 commit into from
May 22, 2024

Conversation

dmbaturin
Copy link
Member

Change Summary

Tell the user to compare or commit after applying the diff, since the procedure is different from the old rollback and the lack of messages may be perceived as if the rollback has already occurred.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): behavior change.

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@jestabro jestabro merged commit 5e7cf7d into vyos:current May 22, 2024
8 checks passed
@dmbaturin
Copy link
Member Author

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented May 22, 2024

backport sagitta

✅ Backports have been created

jestabro added a commit that referenced this pull request May 22, 2024
rollback-soft: T6384: tell the user to compare or commit (backport #3501)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants