nat64: T6403: validate source prefix for RFC compliance #3572
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Simplest fix is to comply with RFC6052. The code change is just masking out the relevant bits and ensuring they're zeroed.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
This just ensures the configured source prefix will be accepted by Jool.
It may be preferable to --force the config for maximum flexibility, but I've opted for standards compliance here (and it's a bit less work).
How to test
Smoketest result
$ python3 /usr/libexec/vyos/tests/smoke/cli/test_nat64.py
test_snat64 (main.TestNAT64.test_snat64) ... ok
Ran 1 test in 12.396s
OK
Checklist: