Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6431: op-mode command "monitor traceroute" missing recursive symlink (backport #3582) #3583

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 5, 2024

Change Summary

There's 4 opmode commands with flexible leafNode parameters, sort of "varargs", using some symlink hackery to work. ping, traceroute and mtr were correctly symlinked in the Makefile, monitor traceroute was not.

The completion help texts were also switched between mtr and monitor traceroute, they're in the same XML def.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

  • monitor

Proposed changes

Added the missing symlink and swapped around the help text.

How to test

Before the patch:

vyos@TEST-VYOS-LEFT:~$ monitor traceroute 8.8.8.8 vrf 
Possible completions:
  <Enter>               Execute the current command

After the patch:

vyos@TEST-VYOS-LEFT:~$ monitor traceroute 8.8.8.8 vrf 
Possible completions:
  <Enter>               Execute the current command
  MGT                   Traceroute options

      
vyos@TEST-VYOS-LEFT:~$ monitor traceroute 8.8.8.8 vrf MGT 
Possible completions:
  <Enter>               Execute the current command
  address               Traceroute options
  aslookup
  bitpattern
  first-ttl
[...etc...]

Smoketest result

There doesn't appear to be a smoketest for tiny op-mode schema changes.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3582 done by [Mergify](https://mergify.com).

Likely this was copied from mtr in the past but the symlink wasn't added
to the Makefile.

I've also swapped the completion help text around to match the commands.

(cherry picked from commit de1479b)
@mergify mergify bot requested a review from a team as a code owner June 5, 2024 07:45
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Jun 5, 2024
@dmbaturin dmbaturin merged commit 170901b into sagitta Jun 5, 2024
6 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3582 branch June 5, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants