Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6480: must call pki.py helper as root to work with ACME certificates #3645

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Jun 14, 2024

Change Summary

This is an addition to commit 65fba1c ("op-mode: T6377: must call pki.py helper as root to work with ACME certificates") which missed out the basic "show pki" command, as the XML node was deep down in the view.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

vyos@vyos:~$ show pki
Certificate Authorities:
Name                      Subject                                                                                                  Issuer CN                                Issued               Expiry               Private Key    Parent
------------------------  -------------------------------------------------------------------------------------------------------  ---------------------------------------  -------------------  -------------------  -------------  ------------------------

Certificates:
Name    Type    Subject CN          Issuer CN               Issued               Expiry               Revoked    Private Key    CA Present
------  ------  ------------------  ----------------------  -------------------  -------------------  ---------  -------------  -------------------------
foo     Server  CN=ipsec.mybll.net  CN=R10                  2024-06-14 09:29:43  2024-09-12 09:29:42  No         Yes            No

Certificate Revocation Lists:
CA Name    Updated    Revokes
---------  ---------  ---------

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

…tificates

This is an addition to commit 65fba1c ("op-mode: T6377: must call pki.py
helper as root to work with ACME certificates") which missed out the basic
"show pki" command, as the <command> XML node was deep down in the view.
@c-po c-po requested a review from a team as a code owner June 14, 2024 10:39
@c-po
Copy link
Member Author

c-po commented Jun 14, 2024

@Mergifyio backport sagitta

Copy link

👍
No issues in PR Title / Commit Title

Copy link
Contributor

mergify bot commented Jun 14, 2024

backport sagitta

✅ Backports have been created

@c-po c-po enabled auto-merge June 14, 2024 11:34
@c-po c-po merged commit f3d3b0f into vyos:current Jun 14, 2024
9 checks passed
@c-po c-po deleted the pki-T6480 branch June 15, 2024 06:15
@c-po
Copy link
Member Author

c-po commented Jun 17, 2024

@Mergifyio backport sagitta-stream circinus-stream

Copy link
Contributor

mergify bot commented Jun 17, 2024

backport sagitta-stream circinus-stream

✅ Backports have been created

c-po added a commit that referenced this pull request Jun 17, 2024
op-mode: T6480: must call pki.py helper as root to work with ACME certificates (backport #3645)
c-po added a commit that referenced this pull request Jun 24, 2024
op-mode: T6480: must call pki.py helper as root to work with ACME certificates (backport #3645)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants