Skip to content

T6619: Remove the remaining uses of per-protocol FRR configs (backport #3916) #3957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 8, 2024

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

conf
set protocols static multicast route 224.202.0.0/24 next-hop 224.203.0.1
set protocols static multicast interface-route 224.203.0.0/24 next-hop-interface eth0 
commit
vtysh -c 'show running-config'

Smoketest result

vyos@vyos:~$ python3 /usr/libexec/vyos/tests/smoke/cli/test_protocols_static_multicast.py 
test_01_static_multicast (__main__.TestProtocolsStaticMulticast.test_01_static_multicast) ... ok

----------------------------------------------------------------------
Ran 1 test in 6.213s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3916 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner August 8, 2024 07:43
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Aug 8, 2024

👍
No issues in unused-imports

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't ever updating FRR in 1.4 to 10.x, but this doesn't harm, I suppose.

@sever-sever sever-sever self-requested a review August 8, 2024 11:49
@c-po c-po self-assigned this Aug 12, 2024
@c-po c-po enabled auto-merge August 12, 2024 20:18
@c-po c-po merged commit 8baa5b5 into sagitta Aug 13, 2024
8 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3916 branch August 13, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

4 participants