utils: T6658: fix write_file check in case of empty directory path #3989
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix check if dirname empty. This is a minor error, but an annoyance after the revisions to the migration system (T6007; not yet backported), which make use of the util
write_file
forvyos-save-config.py
, looking ahead to making config write operations atomic (T6472).For example, one may want to save a config locally:
save some-config
without dirpath, which will raise the error:FileNotFoundError: [Errno 2] No such file or directory: ''
Fix now and backport.
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: