Skip to content

pppoe: T6930: Remove unnecessary code #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2024
Merged

pppoe: T6930: Remove unnecessary code #4246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions python/vyos/ifconfig/pppoe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,14 +115,6 @@ def update(self, config):
# before this is done by the base class.
self._config = config

# remove old routes from an e.g. old VRF assignment
if 'shutdown_required':
vrf = None
tmp = get_interface_config(self.ifname)
if 'master' in tmp:
vrf = tmp['master']
self._remove_routes(vrf)

# DHCPv6 PD handling is a bit different on PPPoE interfaces, as we do
# not require an 'address dhcpv6' CLI option as with other interfaces
if 'dhcpv6_options' in config and 'pd' in config['dhcpv6_options']:
Expand Down
Loading