Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6971: "monitor log" should have no output color at all #4249

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 21, 2024

Change Summary

There was an invalid attempt to remove journalctl output colour. Unfortunately it does not work 100% and it needs a different environment variable.

This fixes commit 9a85d8b.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Proposed changes

How to test

image

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Dec 21, 2024

👍
No issues in PR Title / Commit Title

There was an invalid attempt to remove journalctl output colour. Unfortunately
it does not work 100% and it needs a different environment variable.

This fixes commit 9a85d8b.
@c-po c-po force-pushed the journalctl-colour branch from b11d440 to f15e522 Compare December 21, 2024 22:34
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit b460cbc into vyos:current Dec 22, 2024
14 of 16 checks passed
@c-po c-po deleted the journalctl-colour branch December 22, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants