Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smoketest: T6746: T5791: additional fixes/logic hardening #4252

Merged
merged 2 commits into from
Dec 23, 2024
Merged

smoketest: T6746: T5791: additional fixes/logic hardening #4252

merged 2 commits into from
Dec 23, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Dec 23, 2024 •
edited
Loading

Change Summary

base smoketests: wait after commit() until frr-reload is no longer running. This extends commit 90e9aa9 ("frr: T6746: add guard time after cli_commit() and before getFRRconfig()")

ddclient: This extends commit c2d84b0 ("T5791: Modify ddclient smoketest for reliability").

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

c-po added 2 commits December 23, 2024 13:39
@c-po
smoketest: T6746: wait after commit() until frr-reload is no longer r…
702a60a 
…unning

This extends commit 90e9aa9 ("frr: T6746: add guard time after cli_commit()
and before getFRRconfig()").
@c-po
smoketest: T5791: add guard timeout when checking for ddclient process
e1d34e5 
This extends commit c2d84b0 ("T5791: Modify ddclient smoketest for
reliability").
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@github-actions GitHub Actions
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@c-po c-po merged commit 6f6aa04 into vyos:current Dec 23, 2024
17 of 19 checks passed
@c-po c-po deleted the smoketest-fixes branch December 23, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort nicolas-fort is a code owner

@zdc zdc Awaiting requested review from zdc zdc is a code owner

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-po @sever-sever