frr: T6746: additional improvements after 10.2 upgrade #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-po
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
fett0,
nicolas-fort and
zdc
as code owners
|
👍 |
c-po
force-pushed
the
frr-10-improvements
branch
from
4e51d79 to
e1b6908
Compare
dmbaturin
requested changes
Dec 28, 2024
Some daemons (e.g. bgpd) have several nested substrings/sections like router bgp 100 address-family ipv4 unicast .. exit-address-family exit We can now use getFRRconfig() with the substring option to extract only address-family ipv4 unicast .. exit-address-family Making config validation more granular
c-po
force-pushed
the
frr-10-improvements
branch
from
e1b6908 to
990e93d
Compare
It was an invalid workarround as the underlaying issue seems to be a race condition in CStore. The commit process is not finished until all pending files from VYATTA_CHANGES_ONLY_DIR are copied to VYATTA_ACTIVE_CONFIGURATION_DIR. This is done inside libvyatta-cfg1 and the FUSE UnionFS part. On large non-interactive commits FUSE UnionFS might not replicate the real state in time, leading to errors when querying the working and effective configuration. TO BE DELETED AFTER SWITCH TO IN MEMORY CONFIG
c-po
force-pushed
the
frr-10-improvements
branch
from
990e93d to
b1bf25e
Compare
|
CI integration 👍 passed! Details
|
sever-sever
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Some daemons (e.g.
bgpd) have several nested substrings/sections likeWe can now use getFRRconfig() with the substring option to extract only
Making config validation more granular
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Checklist: