Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddclient: T5791: Relocate process params to ExecStart #4283

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

indrajitr
Copy link
Contributor

Change summary

Pull up all the global parameters controlling process behavior to systemd service.

Also remove syslog=yes as it is not needed with exec type service.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T5791

Related PR(s)

How to test / Smoketest result

vyos@gw:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_dns_dynamic.py 
test_01_dyndns_service_standard (__main__.TestServiceDDNS.test_01_dyndns_service_standard) ... ok
test_02_dyndns_service_ipv6 (__main__.TestServiceDDNS.test_02_dyndns_service_ipv6) ... ok
test_03_dyndns_service_dual_stack (__main__.TestServiceDDNS.test_03_dyndns_service_dual_stack) ... ok
test_04_dyndns_rfc2136 (__main__.TestServiceDDNS.test_04_dyndns_rfc2136) ... ok
test_05_dyndns_hostname (__main__.TestServiceDDNS.test_05_dyndns_hostname) ... ok
test_06_dyndns_web_options (__main__.TestServiceDDNS.test_06_dyndns_web_options) ... ok
test_07_dyndns_dynamic_interface (__main__.TestServiceDDNS.test_07_dyndns_dynamic_interface) ... ok
test_08_dyndns_vrf (__main__.TestServiceDDNS.test_08_dyndns_vrf) ... ok

----------------------------------------------------------------------
Ran 8 tests in 411.525s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jan 6, 2025

👍
No issues in PR Title / Commit Title

@indrajitr indrajitr force-pushed the ddclient-update-20250106 branch from 538b55b to a2a3ff9 Compare January 7, 2025 15:41
@indrajitr
Copy link
Contributor Author

Smoketest failure looks unrelated

image

@c-po
Copy link
Member

c-po commented Jan 9, 2025

It is indeed and already fixed

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other then the requested changes it loogs good to me

smoketest/scripts/cli/test_service_dns_dynamic.py Outdated Show resolved Hide resolved
smoketest/scripts/cli/test_service_dns_dynamic.py Outdated Show resolved Hide resolved
smoketest/scripts/cli/test_service_dns_dynamic.py Outdated Show resolved Hide resolved
Pull up all the global parameters controlling
process behavior to systemd service.

Also remove `syslog=yes`` as it is not needed with
`exec` type service.
@indrajitr indrajitr force-pushed the ddclient-update-20250106 branch from a2a3ff9 to a328575 Compare January 9, 2025 16:17
@indrajitr
Copy link
Contributor Author

Thanks @c-po! Updated the PR.

@c-po c-po merged commit 726dcee into vyos:current Jan 9, 2025
10 of 13 checks passed
Copy link

github-actions bot commented Jan 9, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests ❌ failed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants