-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddclient: T5791: Relocate process params to ExecStart #4283
Merged
+16
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indrajitr
requested review from
dmbaturin,
sarthurdev,
jestabro,
sever-sever,
c-po,
fett0,
nicolas-fort and
zdc
as code owners
January 6, 2025 17:56
👍 |
c-po
requested changes
Jan 7, 2025
indrajitr
force-pushed
the
ddclient-update-20250106
branch
from
January 7, 2025 15:41
538b55b
to
a2a3ff9
Compare
It is indeed and already fixed |
c-po
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other then the requested changes it loogs good to me
Pull up all the global parameters controlling process behavior to systemd service. Also remove `syslog=yes`` as it is not needed with `exec` type service.
indrajitr
force-pushed
the
ddclient-update-20250106
branch
from
January 9, 2025 16:17
a2a3ff9
to
a328575
Compare
Thanks @c-po! Updated the PR. |
c-po
approved these changes
Jan 9, 2025
sarthurdev
approved these changes
Jan 9, 2025
CI integration ❌ failed! Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Pull up all the global parameters controlling process behavior to systemd service.
Also remove
syslog=yes
as it is not needed withexec
type service.Types of changes
Related Task(s)
https://vyos.dev/T5791
Related PR(s)
How to test / Smoketest result
Checklist: