Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opmode: T7084: reorganize the op mode cache format for ease of search #4313

Open
wants to merge 2 commits into
base: current
Choose a base branch
from

Conversation

dmbaturin
Copy link
Member

Change summary

  • Move node children to children field.
  • Flatten node dicts and move properties (completion help, etc.) to the top level.
[
  {
    "name": "show",
    "type": "node",
    "comp_help": {},
    "command": null,
    "path": [
      "show"
    ],
    "children": [
      {
        "name": "kernel",
        "type": "node",
        "comp_help": {},
        "command": null,
        "path": [
          "show",
          "kernel"
        ],
        "children": [
          {
            "name": "modules",
            "type": "node",
            "comp_help": {},
            "command": "sudo /usr/libexec/vyos//op_mode/kernel_modules.py show",
            "path": [
              "show",
              "kernel",
              "modules"
            ],
            "children": []
          }
        ]
      }
    ]
  },

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Jan 23, 2025

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin force-pushed the T7084-op-mode-cache-reorg branch 4 times, most recently from 5550a7f to a1a9aaf Compare January 23, 2025 18:32
@dmbaturin dmbaturin force-pushed the T7084-op-mode-cache-reorg branch from a1a9aaf to 937714f Compare January 23, 2025 18:35
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants