Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoketest: T6911: fix wrong router-id in loaded config validation #4316

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented Jan 24, 2025

Change summary

Change some values from the defaults in the used smoketest config for basic-vyos-no-ntp to make it a litte bit more interesting for the underlaying config load subsystem.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

c-po added 2 commits January 24, 2025 07:28
An errornous OSPF router-id slipped through in the config load test validation.
…test

Change some values from the defaults in the used smoketest config for
basic-vyos-no-ntp to make it a litte bit more interesting for the underlaying
config load subsystem.
Copy link

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit b759dad into vyos:current Jan 24, 2025
10 checks passed
@c-po c-po deleted the ntp-ease-smoketest-T6911 branch January 24, 2025 06:43
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant