T7089: Fix static route when using PPPoE default route

[sskaje]

Change summary

Fix static route when using PPPoE default route

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

https://vyos.dev/T7089

Related PR(s)

How to test / Smoketest result

live image with ethernet dhcp + service ssh + pppoe configured.

root@vyos:/home/vyos# /usr/libexec/vyos/tests/smoke/cli/test_protocols_static.py 
test_01_static (__main__.TestProtocolsStatic.test_01_static) ... ok
test_02_static_table (__main__.TestProtocolsStatic.test_02_static_table) ... ok
test_03_static_vrf (__main__.TestProtocolsStatic.test_03_static_vrf) ... FAIL
test_04_static_multicast (__main__.TestProtocolsStatic.test_04_static_multicast) ... ok
test_05_dhcp_default_route (__main__.TestProtocolsStatic.test_05_dhcp_default_route) ... skipped 'Not running under VyOS CI/CD QEMU environment!'

======================================================================
FAIL: test_03_static_vrf (__main__.TestProtocolsStatic.test_03_static_vrf)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/libexec/vyos/tests/smoke/cli/test_protocols_static.py", line 189, in tearDown
    self.assertFalse(v4route)
AssertionError: 'ip route 0.0.0.0/0 pppoe0 tag 210\nip route 0.0.0.0/0 192.168.12.1 eth0 tag 210 210\n!' is not false

----------------------------------------------------------------------
Ran 5 tests in 65.275s

FAILED (failures=1, skipped=1)

live image with all default config, test 03 passed, test 05 skipped

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

CI integration 👍 passed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed