T6718: use the vyconf daemon for validation of set commands#31
Merged
dmbaturin merged 14 commits intovyos:currentfrom Nov 7, 2024
Merged
T6718: use the vyconf daemon for validation of set commands#31dmbaturin merged 14 commits intovyos:currentfrom
dmbaturin merged 14 commits intovyos:currentfrom
Conversation
Allow for single-quoted values containing whitespace, as used by vyconf vycli for option --path.
Splitting of path arg into (path, value), as originally returned by validate_path, is now handled by a utility function. validate_path returns unit on success and raises error with output on failure.
This was referenced Oct 26, 2024
dmbaturin
approved these changes
Nov 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This is a companion PR for
vyos/vyconf#11
The vyconf PR provides required updates to vyconfd and the adapter module to vyatta-cfg; this PR provides the required changes to the internal version of validate-value, as run by the daemon, as well as required fixes and utils.
Types of changes
Related Task(s)
Related PR(s)
Proposed changes
How to test
Checklist: