New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Blockscout contract verification #308

Merged

charles-cooper merged 23 commits into vyperlang:master from DanielSchiavini:blockscout

Sep 22, 2024

Collaborator

DanielSchiavini commented Sep 11, 2024 •

edited

Loading

What I did

Implement Blockscout contract verification
Unfortunately, a bug is causing problems when called with boa.loads

How I did it

Allow verification on vyper deployer, vyper blueprints and vyper contract
When feat: VVM injection, internal functions and variables #294 lands, we can also add verification for VVM contracts.

How to verify it

tests are included
see example verified contract

Description for the changelog

Add contract verification on Blockscout

Cute Animal Picture

DanielSchiavini added 2 commits

September 11, 2024 16:16


          Implement Blockscout contract verification

4b9f82b


          Move verify to deployer

c47b7e7

DanielSchiavini marked this pull request as ready for review

September 11, 2024 14:54

charles-cooper reviewed

View reviewed changes

boa/contracts/vyper/vyper_contract.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/vyper/vyper_contract.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/verify.py Outdated Show resolved Hide resolved

iChristwin reviewed

View reviewed changes

boa/contracts/vyper/vyper_contract.py Show resolved Hide resolved


          fix path resolver

5ce6bfb

Member

charles-cooper commented Sep 11, 2024 •

edited

Loading

i reworked path resolution in 5ce6bfb, it works now.

~~i made the additional change of essentially ignoring the name= parameter, i'm not really sure if anybody uses it though~~

rolled back the contract_name= change in 572ef3f

charles-cooper and others added 7 commits

September 11, 2024 16:36


          bring back VyperContract name

572ef3f


          roll back further

96622c7


          remove workaround

22a9c84


          fix lint

5a72857


          Review comments

f2431ec


          Merge branch 'master' of github.com:vyperlang/titanoboa into blockscout

142c3fb


          Get rid of evm_version

97595c8

charles-cooper reviewed

View reviewed changes

boa/verifiers.py Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

tests/integration/network/sepolia/test_sepolia_env.py Outdated Show resolved Hide resolved


          Remove default value

57bc002

Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>

DanielSchiavini requested a review from charles-cooper

September 13, 2024 09:09

DanielSchiavini mentioned this pull request

Add contract verfication vyperlang/titanoboa-zksync#13

Closed


          roll back line movement

32ea0ee

charles-cooper added 3 commits

September 16, 2024 19:46


          fix api_key and address.lower() usages

c8b5a52

mixed case address should work fine
when api_key is None, can be a bug


          fix: use self.timeout instead of constant

5a580c5


          add set_blockscout function

b82cf7c

charles-cooper reviewed

View reviewed changes

boa/verifiers.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/verifiers.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/verifiers.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/verifiers.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/verifiers.py Outdated Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/vyper/vyper_contract.py Outdated Show resolved Hide resolved

DanielSchiavini added 2 commits

September 19, 2024 20:26


          Rename to verifier, use it in vyper contract

7b9042d


          boa.verify

97bd2b1

charles-cooper reviewed

View reviewed changes

boa/contracts/vyper/vyper_contract.py Show resolved Hide resolved

charles-cooper reviewed

View reviewed changes

boa/contracts/vyper/vyper_contract.py Outdated Show resolved Hide resolved

charles-cooper added 6 commits

September 21, 2024 19:42


          remove BaseVyperContract.verify

a0a8a67


          make is_verified() a function rather than property


          sleep after initial ping, not before

14fbfff


          clean up some code, add wait=False parameter

57c6b0b


          move boa.verify to verifiers

60dba56


          update test

72d93d1

charles-cooper merged commit f1051f4 into vyperlang:master

9 checks passed

DanielSchiavini deleted the blockscout branch

September 22, 2024 08:19

charles-cooper mentioned this pull request

feat: add contract verify on blockscout and etherscan #303

Closed

Leminkay pushed a commit to Leminkay/titanoboa that referenced this pull request


          feat: Blockscout contract verification (vyperlang#308)

4d05b22

implement Blockscout contract verification

main entry points are `boa.verify` and `boa.set_verifier(Blockscout(...))`

---------

Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet