fix: refresh wallet address before signing #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,6 +160,7 @@ def test_browser_signer_colab(colab_eval_mock, mocked_token, display_mock): | |||
| address = boa.env.generate_address() | |||
| colab_eval_mock.return_value = json.dumps({"data": [address]}) | |||
| signer = BrowserSigner() | |||
| signer.update() | |||
There was a problem hiding this comment.
i guess BrowserSigner should call update() in the ctor
charles-cooper
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
boa.env.eoais not updated on address changes #309 by refreshing the wallet address before signingHow I did it
BrowserEnv.eoais usedaccountChangedJavaScript event;How to verify it
boa.env.eoais not updated on address changes #309 should work againDescription for the changelog
Cute Animal Picture