feat: Detect Vyper version from source #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielSchiavini
force-pushed
the
detect-version
branch
from
acc5243
to
1571879
Compare
DanielSchiavini
changed the title
detect_vyper_version_from_source
vvm/main.py
Outdated
| --------- | ||
| specifier : SpecifierSet | ||
| Specifier to pick a version for. | ||
| prereleases : bool, optional |
There was a problem hiding this comment.
either default to false (kosher, since False is not a mutable in python), or add a line in the function body like if prereleases is None: prereleases = False
There was a problem hiding this comment.
the packaging lib will only choose prereleases when they are the only ones available
There was a problem hiding this comment.
i'm more talking about the default value -- no need to pick between None, True and False
There was a problem hiding this comment.
I think None is the correct value here
DanielSchiavini
commented
Sep 13, 2024
Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
charles-cooper
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Checklist