fix: reject npm-style version specifiers above v0.4.0 #24

DanielSchiavini · 2024-09-17T11:09:26Z

FIxed issue when using the "^0.x.y" specifier
According to semver.npmjs.com the caret should work differently for 0.x versions
For example:

fix by rejecting npm-style specifiers above v0.4.0

vvm/utils/versioning.py

tests/test_versioning.py

Fix issue with ^0. version specifiers

b3e2895

DanielSchiavini mentioned this pull request Sep 17, 2024

Fix for VVM with non-fixed version pragma vyperlang/titanoboa#315

Open

Reject npm specifier for >=0.4.0

0d3522c

charles-cooper reviewed Sep 17, 2024

View reviewed changes

vvm/utils/versioning.py Outdated Show resolved Hide resolved

Unreachable Code

557c171

charles-cooper reviewed Sep 17, 2024

View reviewed changes

tests/test_versioning.py Outdated Show resolved Hide resolved

Update tests/test_versioning.py

d7c2e0e

charles-cooper reviewed Sep 17, 2024

View reviewed changes

tests/test_versioning.py Show resolved Hide resolved

Update tests/test_versioning.py

1dc2edd

charles-cooper reviewed Sep 17, 2024

View reviewed changes

tests/test_versioning.py Outdated Show resolved Hide resolved

Update tests/test_versioning.py

2930b45

charles-cooper changed the title ~~fix: issue with ^0. version specifiers~~ fix: reject npm-style version specifiers above v0.4.0 Sep 17, 2024

charles-cooper merged commit f813e1f into vyperlang:master Sep 17, 2024
9 of 10 checks passed

DanielSchiavini deleted the detect-version branch September 17, 2024 15:29

Provide feedback