fix unused variables pass

it corrupts the DFG. to see the bug before this commit, add another StoreEliminationPass after RemoveUnusedVariablesPass.
vyperlang · Sep 25, 2024 · 3b2ece2 · 3b2ece2
1 parent 48a5da4
commit 3b2ece2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/vyper/venom/analysis/dfg.py b/vyper/venom/analysis/dfg.py
@@ -31,6 +31,9 @@ def remove_use(self, op: IRVariable, inst: IRInstruction):
         uses = self._dfg_inputs.get(op, [])
         uses.remove(inst)
 
+    def remove_var(self, op: IRVariable):
+        self._dfg_outputs.pop(op)
+
     @property
     def outputs(self) -> dict[IRVariable, IRInstruction]:
         return self._dfg_outputs

diff --git a/vyper/venom/passes/remove_unused_variables.py b/vyper/venom/passes/remove_unused_variables.py
@@ -42,4 +42,5 @@ def _process_instruction(self, inst):
             new_uses = self.dfg.get_uses(operand)
             self.work_list.addmany(new_uses)
 
+        self.dfg.remove_var(inst.output)
         inst.parent.remove_instruction(inst)