Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[lang]: fix importing of flag types #3871

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

cyberthirst
Copy link
Collaborator

@cyberthirst cyberthirst commented Mar 18, 2024

What I did

How I did it

How to verify it

  • wrote a new test for flag imports: test_flag_imports.py

Commit message

fix imports for flag types. this is a missed case from 8ccacb3f47f.

this commit adds flags into the module data and threads them through
codegen.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper changed the title fix: import of flag types fix[lang]: fix importing of flag types Mar 19, 2024
@charles-cooper charles-cooper marked this pull request as ready for review March 19, 2024 21:17
@charles-cooper charles-cooper enabled auto-merge (squash) March 19, 2024 21:24
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.38%. Comparing base (e589278) to head (b180e2f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3871      +/-   ##
==========================================
+ Coverage   86.33%   86.38%   +0.04%     
==========================================
  Files          92       92              
  Lines       14010    14017       +7     
  Branches     3077     3079       +2     
==========================================
+ Hits        12096    12108      +12     
+ Misses       1484     1480       -4     
+ Partials      430      429       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@charles-cooper charles-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@charles-cooper charles-cooper merged commit 05ec5a1 into vyperlang:master Mar 19, 2024
146 checks passed
electriclilies pushed a commit to electriclilies/vyper that referenced this pull request Apr 27, 2024
fix imports for flag types. this is a missed case from 8ccacb3.

this commit adds flags into the module data and threads them through
codegen.

---------

Co-authored-by: Charles Cooper <cooper.charles.m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants