-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[venom]: fix _stack_reorder()
routine
#4220
Merged
charles-cooper
merged 13 commits into
vyperlang:master
from
HodanPlodky:fix/snek-shanghaierror
Oct 4, 2024
Merged
Changes from 4 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b8b261a
fix[venom]: stack reorder rework
HodanPlodky 8db93fa
fix[venom]: stack reorder rework (lint)
HodanPlodky aed28e3
fix[venom]: small improvement
HodanPlodky 0050f2f
Merge branch 'master' into fix/snek-shanghaierror
HodanPlodky d961406
small refactor (factoring out the vars) + bit of documentation
HodanPlodky eedeecf
small refactor (factoring out the vars) + bit of documentation
HodanPlodky 52b1c41
stack reorder regression test
HodanPlodky 52777bc
stack reorder regression test (lint)
HodanPlodky 3cde8a5
stack reorder regression test (lint)
HodanPlodky b3ed033
Merge branch 'master' into fix/snek-shanghaierror
charles-cooper 81ce4f8
Merge branch 'master' into fix/snek-shanghaierror
charles-cooper 76441a8
cleanup
charles-cooper c69683b
Merge branch 'master' into fix/snek-shanghaierror
charles-cooper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the
positions[stack.peek(final_stack_depth)]
can be factored out into a variable