feat[venom]: new DFTPass algorithm
#4255
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This reverts commit e3c3ba4.
Co-authored-by: Harry Kalogirou <harkal@nlogn.eu>
Co-authored-by: HodanPlodky <36966616+HodanPlodky@users.noreply.github.com>
| # | ||
| # Apply effects to dependency graph | ||
| # | ||
| last_effects = {} |
Check notice
Code scanning / CodeQL
Unused local variable Note
| # | ||
| last_effects = {} | ||
| last_volatile = None | ||
| terminator_inst = non_phis[-1] |
Check notice
Code scanning / CodeQL
Unused local variable Note
vyper/venom/passes/dft.py
Outdated
| # for write_effect in write_effects: | ||
| # if write_effect in last_effects: | ||
| # self.ida[inst].append(last_effects[write_effect]) | ||
| # last_effects[write_effect] = inst | ||
|
|
||
| self.fence_id = 0 | ||
| # for read_effect in read_effects: | ||
| # if read_effect in last_effects: | ||
| # self.ida[inst].append(last_effects[read_effect]) |
Check notice
Code scanning / CodeQL
Commented-out code Note
…s' into feat/dft_upgrade
| @@ -239,6 +236,34 @@ | |||
| @property | |||
| def is_bb_terminator(self) -> bool: | |||
| return self.opcode in BB_TERMINATORS | |||
|
|
|||
| def get_read_effects(self): | |||
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
| def get_read_effects(self): | ||
| return effects.reads.get(self.opcode, ()) | ||
|
|
||
| def get_write_effects(self): |
Check warning
Code scanning / CodeQL
Variable defined multiple times Warning
What I did
I upgraded the DFT algorithm to allow for more instruction movement. It also removes the use of order ids and sorting. It results generally smaller code, and opens up the road for multi-dimensional fencing.
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture