fix[ux]: empty hint

[sandbubbles]

What I did

Remove empty hint message from exceptions. As in #4313.

How I did it

Modify the check of absent hint to include an empty string.

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

[sandbubbles]

UndeclaredException is the only place where I encountered empty hints. An alternative solution is to add the check there to prevent the hint from being an empty string in the first place.

[charles-cooper]

It seems like a code smell that we are creating empty string hints in the first place. Do we know where they are coming from?

[sandbubbles]

It seems like a code smell that we are creating empty string hints in the first place. Do we know where they are coming from?

I think its as in this - #4351 (comment) - just the UndeclaredException. But I can spend some more time if i encounter it elsewhere.

[charles-cooper]

note the regression comes from #4154 -- the previous code checked for truthy value of self.hint.

[sandbubbles]

note the regression comes from #4154 -- the previous code checked for truthy value of self.hint.

Yeah, I think there are two main solutions:

1. Have the check in the same way as pre fix[ux]: empty hint #4351 - (which is proposed in this PR, because i though hint can be only None or string, but I can rewrite it to if not hint to keep the truthyness).
2. Or keep the current test if hint is None and modify get_levenshtein_error_suggestions to return None instead of an empty string (which is used as the hint in one type of UndeclaredDefinition)

I think the second solution is cleaner, but the first solution ensures that we catch any missed empty string hints.
What do you prefer?

[charles-cooper]

i think 2. is better -- we should not be supplying empty string as a hint!

[sandbubbles]

i think 2. is better -- we should not be supplying empty string as a hint!

Hope its better now :)