Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[venom]: make dft-pass commutative aware #4358

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

use the "choice" heuristic for commutative instructions

refactor/misc:
some small code cleanup in dft pass

What I did

How I did it

How to verify it

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

use the "choice" heuristic for commutative instructions

refactor/misc:
some small code cleanup in dft pass
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 45.94%. Comparing base (c32b9b4) to head (1ebc876).

Files with missing lines Patch % Lines
vyper/venom/passes/dft.py 0.00% 9 Missing ⚠️
vyper/venom/basicblock.py 40.00% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c32b9b4) and HEAD (1ebc876). Click for more details.

HEAD has 139 uploads less than BASE
Flag BASE (c32b9b4) HEAD (1ebc876)
140 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4358       +/-   ##
===========================================
- Coverage   91.23%   45.94%   -45.30%     
===========================================
  Files         112      112               
  Lines       16010    16015        +5     
  Branches     2697     2699        +2     
===========================================
- Hits        14607     7358     -7249     
- Misses        968     8097     +7129     
- Partials      435      560      +125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants