feat: added the dialog route behavior and also modified the message w…

…hen a cms route fails to load
vyuh-tech · Mar 23, 2024 · 4a5b705 · 4a5b705
1 parent 546c5d3
commit 4a5b705
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/system/vyuh_extension_content/lib/ui/route_builder.dart b/packages/system/vyuh_extension_content/lib/ui/route_builder.dart
@@ -74,7 +74,7 @@ class _RouteFutureBuilderState extends State<RouteFutureBuilder> {
                 vyuh.analytics.reportError(exception);
 
                 return vyuh.widgetBuilder.errorView(
-                  title: 'Failed to load route',
+                  title: 'Failed to load route from CMS',
                   error: exception,
                   onRetry: _refresh,
                 );

diff --git a/packages/system/vyuh_feature_system/lib/content/route/route_type.dart b/packages/system/vyuh_feature_system/lib/content/route/route_type.dart
@@ -45,6 +45,10 @@ final class DialogRouteType extends RouteTypeConfiguration {
 
   @override
   Page<T> create<T>(Widget child, vc.RouteBase route) {
-    return ModalDialogPage(builder: (context) => child);
+    return switch (behavior) {
+      DialogBehavior.modalBottomSheet =>
+        ModalDialogPage(builder: (context) => child),
+      DialogBehavior.fullscreen => DialogPage(builder: (context) => child),
+    };
   }
 }