Add PreLoadedPlugin mixin for pre-initialized plugins #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revamped the handling of preloaded plugins by introducing the PreLoadedPlugin mixin. Applied this mixin to DIPlugin, AnalyticsPlugin, and NetworkPlugin to ensure they are initialized before the platform. Removed the static list of preloadedPlugins from VyuhPlatform.
Convert plugin storage mechanism to a cacheable list for better performance. Change abstract class to use getters instead of final fields, and update methods to work with the new plugin handling structure.
This update modifies the addAll method in default_platform.dart to clear the lookup cache whenever new plugins are added. This ensures that the cache remains consistent with the latest set of plugins.
Replaced the PluginType enumeration with a PluginDescriptor class to handle plugin dependency management. Simplified plugin initialization and retrieval logic, and streamlined the code by removing redundant checks for required plugins.
pavanpodila
requested changes
Sep 15, 2024
packages/system/vyuh_core/lib/runtime/platform/default_platform.dart
Outdated
Show resolved
Hide resolved
|
Keeping it in draft, for few more changes. |
pavanpodila
approved these changes
Sep 18, 2024
|
Fixed the developer feature and also improved the ergonomics of PluginDescriptor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us to mark any plugin to be preloaded without any Change to Vyuh Core.
Revamped the handling of preloaded plugins by introducing the PreLoadedPlugin mixin. Applied this mixin to DIPlugin, AnalyticsPlugin, and NetworkPlugin to ensure they are initialized before the platform. Removed the static list of preloadedPlugins from VyuhPlatform.