Skip to content

Conversation

@helmo
Copy link
Contributor

@helmo helmo commented Nov 13, 2020

This was added in ISPconfig 3.2

Selection_262

@helmo
Copy link
Contributor Author

helmo commented Nov 19, 2020

@thompol could you review this?

@thompol
Copy link

thompol commented Nov 19, 2020

@helmo Gladly. It looks good to me, I suppose you tested it?

@helmo
Copy link
Contributor Author

helmo commented Nov 19, 2020

Sure. It seems to work here, but an extra test is always good ;)

@thompol
Copy link

thompol commented Nov 20, 2020

I have some notes, though I am not responsible for this project :)

  • Maybe these settings should be under filter and not spam, like it is in the ISPConfig UI?
  • The fields are not added to the templates, at least not for elastic, so the fields don't show up in Roundcube. Did you miss committing the files for this?

@helmo
Copy link
Contributor Author

helmo commented Nov 20, 2020

  • Moving to the filters page doesn't seem like a perfect fit either ... maybe general?

  • I didn't have to change any template, thge field is added in ispconfig3_spam/ispconfig3_spam.php

... just tried elastic I also see the fields there.

@thompol
Copy link

thompol commented Nov 20, 2020

Could be in general aswell, but in the ISPConfig UI it's in filters.

My bad, this test system's Roundcube installation is a mess. Fixed it now. Works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants