Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added file to fetch data from the subgraph API. Package.json updated with axios and ts-node. #154

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

RafaDSan
Copy link
Contributor

closes #153

@Guboehm Made the subgraph-queries.ts file using axios to fetch data from the subgraph API.

Copy link

gitguardian bot commented Nov 24, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret ee1ab8e src/services/subgraph-queries.ts View secret
- Generic High Entropy Secret e647082 src/services/subgraph-queries.ts View secret
- Generic High Entropy Secret 6d05195 .env.sample View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@0xneves 0xneves changed the title feat: file added to fetch data from the subgraph API. Package.json updated with axios and ts-node. feat: added file to fetch data from the subgraph API. Package.json updated with axios and ts-node. Dec 7, 2023
Copy link
Member

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm requesting a change to add the auth keys and URL path into the environment file. Fetch them when running the script.

src/services/subgraph-queries.ts Show resolved Hide resolved
@RafaDSan
Copy link
Contributor Author

RafaDSan commented Dec 7, 2023

@0xneves Changes made as suggested!

  • Added the .env-sample file to be fetched by the subgraph-queries.ts file
  • endpoint URL and authorization key are now hidden by the .env
  • package.json updated to accept the dotenv dependencies.

The commit 6d05195 which adds an .env file to the frontend closes #157

Result:
image

Legend: Queries fetched when running the command node subgraph-queries.ts. Obs: Must remove the .sample from .env

@0xneves 0xneves merged commit a33a3ad into w3b3d3v:dev Dec 8, 2023
0 of 3 checks passed
@viniblack viniblack mentioned this pull request Dec 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: integrate subgraph api into the front-end as a library
2 participants