[core-aam PR 221] Update: UIA mappings for elements that had control type text #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #220 updates paragraph and heading mappings to match reality. updates other uia control type mappings to move away from text, as these roles will often contain more than text leaf nodes. other roles could be added to this PR, but will make those updates after discussion with the wg.
13 tasks
|
This PR has more changes than just the ones described in the original comment. I was expecting to only review changes related to the UIA control type. Is this expected? If so, LGTM. |
Ugh - sorry! That's my fault. I clearly overlooked this while I resolved the merge conflicts. @scottaohara let me know if you'd rather fix it yourself. Otherwise I'll try to find time before tomorrow's call. |
pkra
force-pushed
the
monorepo_history--core-aam-PR221
branch
from
513219e
to
25e5ec8
Compare
|
I forced pushed a fixed commit. @scottaohara @benbeaudry would you mind taking another look? |
pkra
force-pushed
the
monorepo_history--core-aam-PR221
branch
from
25e5ec8
to
79b055f
Compare
pkra
changed the title
spectranaut
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported from w3c/core-aam#221
Original description
closes w3c/core-aam#220
updates
paragraphandheadingmappings to match reality.updates other uia control type mappings to move away from text, as these roles will often contain more than text leaf nodes:
caption,code,deletion,termother roles could be added to this PR, but will make those updates after discussion with the wg.
Implementation tracking