Editorial: Add note about submit buttons to popovertarget comments #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a note to reference what is already defined in the HTML spec
spectranaut
changed the title
keithamus
approved these changes
Jun 27, 2024
spectranaut
requested changes
Jun 27, 2024
There was a problem hiding this comment.
When I open this change locally, and respec runs in the browser -- respec can't find the "form owner" definition.
Maybe [=button/form owner=] is what you want? from: https://respec.org/xref/?term=form+owner
scottaohara
commented
Jul 11, 2024
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
keithamus
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Links seem corrected now. This still LGTM; @spectranaut did you want to double check this?
pkra
added
the
editorial
github-actions bot
added a commit
to adampage/aria
that referenced
this pull request
Jul 20, 2024
SHA: 4f38467 Reason: push, by adampage Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a note to reference what is already defined in the HTML spec