Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Add ./github/labeler #2321

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Editorial: Add ./github/labeler #2321

merged 3 commits into from
Oct 14, 2024

Conversation

daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Aug 23, 2024 •
edited
Loading

No description provided.

@netlify Netlify
Copy link

netlify bot commented Aug 23, 2024 •
edited
Loading

✅ Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit b31efa1
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66cc55a163f7f800085016ca
😎 Deploy Preview https://deploy-preview-2321--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@daniel-montalvo daniel-montalvo added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo Agenda-Editors labels Aug 23, 2024
@pkra
Copy link
Member

pkra commented Aug 23, 2024

Looks intriguing! Is there some documentation on how this works?

@daniel-montalvo
Copy link
Contributor Author

@pkra
See https://github.com/actions/labeler

My understanding is that something like this should work

@pkra
Copy link
Member

pkra commented Aug 24, 2024 •
edited by daniel-montalvo
Loading

Thanks @pkra
I missed that.Thanks @daniel-montalvo.

IIUC their documentation correctly, the file needs to be placed in .github/labeler.yml (not .github/ISSUE_TEMPLATE/labeler.yml). We'd also need an accompanying workflow file, e.g., .github/workflows/labeler.yml described at https://github.com/actions/labeler?tab=readme-ov-file#create-workflow

pkra
pkra approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@pkra pkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell (without experience with that action), this looks good.

@daniel-montalvo
Copy link
Contributor Author

Closes #2318

@spectranaut spectranaut merged commit c77c2c6 into main Oct 14, 2024
6 checks passed
@pkra pkra deleted the pr-labeler branch October 14, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkra pkra pkra approved these changes

Assignees
No one assigned
Labels
Agenda-Editors editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-montalvo @pkra @spectranaut