Editorial: Update netlify build to get relative links to specs in PRs #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daniel-montalvo
commented
Aug 28, 2024
•
daniel-montalvo
commented
- Update our Netlify.toml config file
- add a new script that
- changes specStatus to unofficial
- creates new URL mappings for unofficial status to allow for relative links to specs
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
daniel-montalvo
added
editorial
pkra
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
I spot checked a few links in a few specs. It's slightly confusing at first that the regular bibliography links remain the same.
I can still see it being helpful for, e.g., html-aam entries linking the roles to the current PR draft.
Perhaps we should ask someone who requested this if this is helpful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.