-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[html-aam PR 538] Specify AXAPI behaviour for low, high, and optimum meter attributes #2339
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10958,7 +10958,10 @@ <h4 id="att-high">`high`</h4> | |
<tr> | ||
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th> | ||
<td> | ||
<div class="general">Not mapped</div> | ||
<div class="general"> | ||
Expose "optimal value" via `AXValueDescription` if <value> is greater than or equal to <high>. Expose "suboptimal value" if <value> is less than <high> and | ||
greater than or equal to <low>. | ||
</div> | ||
</td> | ||
</tr> | ||
<tr> | ||
|
@@ -11911,7 +11914,10 @@ <h4 id="att-low">`low`</h4> | |
<tr> | ||
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th> | ||
<td> | ||
<div class="general">Not mapped</div> | ||
<div class="general"> | ||
Expose "suboptial value" via `AXValueDescription` if <value> is greater than or equal to <low> and less than <high>. If <value> is less than <low>, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rahimabdi's migrated comment: Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L163 For low: If value is less than or equal to low, then value is "optimal value" |
||
expose "critical value". | ||
</div> | ||
</td> | ||
</tr> | ||
<tr> | ||
|
@@ -13090,7 +13096,7 @@ <h4 id="att-optimum">`optimum`</h4> | |
<tr> | ||
<th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th> | ||
<td> | ||
<div class="general">Not mapped</div> | ||
<div class="general">Expose "optimal value" via `AXValueDescription` if <value> is greater than or equal to <optimum>.</div> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rahimabdi 's migrated comment: Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L184 For optimum: If value is greater than or equal to low AND value is less than or equal to high then value is "optimal value" |
||
</td> | ||
</tr> | ||
<tr> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahimabdi 's migrated comment:
Relevant WebKit code: https://github.com/WebKit/WebKit/blob/c330ea99229f6bb478dde74497ee652e44a3d7d5/Source/WebCore/html/HTMLMeterElement.cpp#L172
This looks correct for high. We'll also need to add the case for when the value is less than "low" (for which this is exposed as "critical value").