Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to the media fragments section #77

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Adding to the media fragments section #77

merged 1 commit into from
Mar 16, 2020

Conversation

wareid
Copy link
Contributor

@wareid wareid commented Mar 16, 2020

Added an additional note about annotations per issue #76.

Lars will add more about deep linking for future revisions.


💥 Error: write EPROTO 140222018242432:error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version:../deps/openssl/openssl/ssl/s23_clnt.c:772:

💥 ###

PR Preview failed to build. (Last tried on Mar 16, 2020, 3:23 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 HTML Diff Service - The HTML Diff Service is used to create HTML diffs of the spec changes suggested in a pull request.

🔗 Related URL

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

Added an additional note about annotations.
@wareid wareid requested review from iherman and mattgarrish March 16, 2020 15:23
@iherman
Copy link
Member

iherman commented Mar 16, 2020

Preview stalled when the PR was made, here is the diff:

https://tinyurl.com/thnafez

@wareid wareid merged commit 55cfbf5 into master Mar 16, 2020
@wareid wareid deleted the media-fragments branch March 16, 2020 16:54
@wareid wareid restored the media-fragments branch March 16, 2020 18:32
@mattgarrish mattgarrish deleted the media-fragments branch July 30, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants