Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thorium Reader test results #53

Merged
merged 9 commits into from
Sep 9, 2020
Merged

Thorium Reader test results #53

merged 9 commits into from
Sep 9, 2020

Conversation

llemeurfr
Copy link
Contributor

This is the result of tests applied to Thorium Reader. It includes generic manifest processing, audiobook specific manifest processing, audiobook UA behaviors, LPF package processing.

The first shot applies to Thorium 1.3, release in June 2020.
In the coming days, other commits will be done, related to updates on W3C pub manifest handling (entry page, html TOC, case insensitive handling of rel values).

@llemeurfr llemeurfr marked this pull request as draft August 31, 2020 17:35
@iherman
Copy link
Member

iherman commented Sep 1, 2020

Wonderful! Thanks a lot @llemeurfr

I have made a PR against this branch in #54 to add the LPF reporting. Otherwise, I checked out this branch on my own machine and, as far as I could see, the reporting with the ThoriumReader works fine. The report surely looks greater with that implementation added :-)

@llemeurfr llemeurfr marked this pull request as ready for review September 9, 2020 13:55
@llemeurfr
Copy link
Contributor Author

llemeurfr commented Sep 9, 2020

The codebase of Thorium Reader has evolved so that PEP and TOC are handled, and rel values in mixed case also.
Most test are now green.
About a4.2.05, this test is problematic, see #55.
About m6.07, the requirement to have the URL of the PEP in manifest resources should IMO be suppressed (see w3c/audiobooks#75) and therefore this test should also be suppressed.

@llemeurfr
Copy link
Contributor Author

The resulting v1.5 will be deployed on early October.

@iherman iherman merged commit 2d07d2b into master Sep 9, 2020
@iherman
Copy link
Member

iherman commented Sep 9, 2020

Thanks @llemeurfr, thorium is now part of the official report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants