-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two new tests with duplicate triples #192
Conversation
@gkellogg I do not know the details of the github action that reports an error. I would leave that in your able hands... |
Without objection, I think we should merge this and allow updated implementation reports to be submitted. |
rdf-canonize passes the tests here and had a local test for this already. It used a variation of the tests here with subject and object blank nodes. Should that be added here too or is it redundant? Input:
Output:
|
If those tests would add something not otherwise caught, then we should add them to this PR. |
True. But I am not sure that tests really add something. The issue to be tested is whether the implementation correctly filters duplicate quads in an nquads representation of a graph, whether those quads/triples include (identical) blank nodes or not. The fact that there is one bnode or there are two does not change the situation imho. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My implementation also passes the added two tests. I will update the report after the PR is merged.
FTR, my implementation also passes these tests |
This PR is to fix #191.
Adds two tests: each contain two identical triples in the input (without and with an identical blank node, respectively); the parsing of the the
nq
files should make it sure that a dataset is canonicalized, ie, the duplication of triples disappear.