Skip to content

Conversation

@quasi-mod
Copy link
Contributor

@quasi-mod quasi-mod commented May 26, 2025

This PR adds the resource timing spec changes for Timing information for SW static routing API.
Explainer here: https://github.com/WICG/service-worker-static-routing-api/blob/main/resource-timing-api.md


Preview | Diff

@quasi-mod
Copy link
Contributor Author

This is still a draft PR.
@yoshisatoyanagisawa @domenic @sisidovski, could you take a look to see if this make sense?

@quasi-mod
Copy link
Contributor Author

I've updated this PR. The fetch-side of change (whatwg/fetch#1832) needs a bit more work (specifically around getting signals), but I think the resource timing side of change is ready to be looked.

Let me ask @yoavweiss for opinions and reviews.

@quasi-mod quasi-mod marked this pull request as ready for review June 5, 2025 01:19
@yoavweiss
Copy link
Contributor

The resource-timing parts look good, but I suspect most of the subtleties will be on the Fetch side..

@quasi-mod
Copy link
Contributor Author

The fetch-side specs are finally settled. (whatwg/fetch#1832)
@yoavweiss , could you recheck and see if this change still makes sense?
Thanks!

Copy link

@yoshisatoyanagisawa yoshisatoyanagisawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-owner lgtm.

@yoavweiss
Copy link
Contributor

The fetch-side specs are finally settled. (whatwg/fetch#1832)
@yoavweiss , could you recheck and see if this change still makes sense?
Thanks!

Is it possible to land the fetch-side PR first?

@quasi-mod
Copy link
Contributor Author

Thanks, the fetch PR had just been merged

@quasi-mod
Copy link
Contributor Author

Fixed the CI issue. PTAL again. Thanks!

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quasi-mod
Copy link
Contributor Author

Thanks for the review!
@yoavweiss Unfortunately, I do not have merge permission, so it would be great if you could merge the changes.

@yoavweiss yoavweiss merged commit 093be0b into w3c:gh-pages Dec 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants