Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new optional rpId to Credential Record #2258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −0
Open

Add a new optional rpId to Credential Record #2258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
831ec20
Define new `rpId` in Credential Record
MasterKale Feb 12, 2025
86b0053
Populate rpId during registration
MasterKale Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,6 +1127,12 @@ BCP 14 [[!RFC2119]] [[!RFC8174]] when, and only when, they appear in all capital
when the [=public key credential source=] was [=registration|registered=].
Storing this in combination with the above [$credential record/attestationObject$] [=struct/item=]
enables the [=[RP]=] to re-verify the [=attestation signature=] at a later time.

: <dfn>rpId</dfn>
:: The value of the <code>{{PublicKeyCredentialCreationOptions/rp}}.{{PublicKeyCredentialRpEntity/id}}</code> parameter
specified in the {{CredentialsContainer/create()}} operation during credential registration.
Storing this enables the [=[RP]=] to use the credential across different domains later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Storing this enables the [=[RP]=] to use the credential across different domains later
This is a core property of a credential and storing the value at creation time is recommended to assist with future operations such as audits, troubleshooting, or leveraging features such as [[#sctn-related-origins|Related Origin Requests]].

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some starter text. needs some work.

via [[#sctn-related-origins|Related Origins]].
</dl>

[=WebAuthn extensions=] MAY define additional [=struct/items=] needed to process the extension.
Expand Down Expand Up @@ -6036,6 +6042,9 @@ a numbered step. If outdented, it (today) is rendered as a bullet in the midst o

: [$credential record/attestationClientDataJSON$]
:: <code>|response|.{{AuthenticatorResponse/clientDataJSON}}</code>.

: [$credential record/rpId$]
:: <code>|pkOptions|.{{PublicKeyCredentialCreationOptions/rp}}.{{PublicKeyCredentialRpEntity/id}}</code>
</dl>

The [=[RP]=] MAY also include any additional [=struct/items=] as necessary.
Expand Down