-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update
browsingContext.print
command with semantic types
This PR does a few things: - Renames `page`, `pageRanges`, `browsingContext.PrintMarginParameters`, and ` browsingContext.PrintPageParameters` to `dimensions`, `range`, `browsingContext.PageMargin`, and `browsingContext.PageDimension`. - Removes the `text` production for `range` in favor of the less complicated `browsingContext.PageRange`. - Adds an algorithm for getting the set of pages from the `range` The motivation for this PR is twofold: 1. The names of some of the parameters are not clear on inspection. 2. The algorithm for `pageRanges` is overly complicated for something that results in the production described in this PR.
- Loading branch information
1 parent
ddabede
commit 443fc54
Showing
1 changed file
with
41 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters