Add network.BytesValue type
#472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagowfx
approved these changes
Jul 5, 2023
|
@juliandescottes can you review this? |
thiagowfx
reviewed
Jul 5, 2023
thiagowfx
approved these changes
Jul 5, 2023
jimevans
reviewed
Jul 5, 2023
This provides a uniform representation of network data that may be UTF-8 text or may be arbitary binary data. Non-UTF-8 data is always encoded as base64 for transport. This is a backwards-incompatible change since it coverts the network.Cookie and network.Headers types from either having a `value` or `binaryValue` field to always having a `value` field, but the value being an object with a `type` field to distinguish the variants.
jrandolf-2
force-pushed
the
network_bytes_value
branch
from
efa3987
to
664d2df
Compare
jimevans
approved these changes
Jul 6, 2023
juliandescottes
approved these changes
Jul 10, 2023
index.bs
Outdated
Comment on lines
3601
to
3608
| 1. If |bytes| matches the <code>network.StringValue</code> production, | ||
| let |protocol value| be [=UTF-8 encode=] |bytes|["<code>value</code>"]. | ||
|
|
||
| 1. Otherwise if |bytes| matches the <code>network.Base64Value</code> | ||
| production. Let |protocol value| be [=forgiving-base64 decode=] | ||
| |bytes|["<code>value</code>"]. | ||
|
|
||
| 1. Return |protocol value|. |
There was a problem hiding this comment.
I'm not sure about the serialization steps? We should not expect bytes to match one of those productions, but rather decide based on whether it's valid UTF 8 or not?
There was a problem hiding this comment.
Oh wow, yes, this is total nonsense :)
Co-authored-by: Julian Descottes <jdescottes@mozilla.com> Co-authored-by: Thiago Perrotta <tperrotta@chromium.org>
thiagowfx
approved these changes
Jul 10, 2023
juliandescottes
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a uniform representation of network data that may be UTF-8 text or may be arbitary binary data. Non-UTF-8 data is always encoded as base64 for transport.
This is a backwards-incompatible change since it coverts the network.Cookie and network.Headers types from either having a
valueorbinaryValuefield to always having avaluefield, but the value being an object with atypefield to distinguish the variants.Preview | Diff