Use script.LocalValue for arguments and this
#477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf-2
force-pushed
the
jrandolf/use-local-value
branch
from
e2cac52
to
7fc65e4
Compare
thiagowfx
reviewed
Jul 6, 2023
thiagowfx
approved these changes
Jul 6, 2023
jrandolf-2
force-pushed
the
jrandolf/use-local-value
branch
from
7fc65e4
to
ada8256
Compare
jgraham
requested changes
Jul 10, 2023
There was a problem hiding this comment.
I think this is OK. The main change seems to be that we allow clients to send maps with channels or remote values as arguments.
The description of script.LocalValue needs to be updated to match the change.
I think adding all these types to local-cddl is wrong; I don't think clients ever have to parse these values.
jrandolf-2
force-pushed
the
jrandolf/use-local-value
branch
from
ada8256
to
6eda744
Compare
Sure, but CDDL complains about unknown types if you don't include it because LocalValue references it and LocalValue exists in |
According to the steps, `script.LocalValue` must include `script.RemoteReference` and `script.ChannelValue`. A priori, there is no purpose in `script.ArgumentValue`
jrandolf-2
force-pushed
the
jrandolf/use-local-value
branch
from
6eda744
to
829f709
Compare
|
As discussed offline, the solution is to just make |
jgraham
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the steps,
script.LocalValuemust includescript.RemoteReferenceandscript.ChannelValue. A priori, there is no purpose inscript.ArgumentValuePreview | Diff