Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorResponse should always have id #479

Closed
wants to merge 2 commits into from
Closed

ErrorResponse should always have id #479

wants to merge 2 commits into from

Conversation

Lightning00Blade
Copy link
Contributor

@Lightning00Blade Lightning00Blade commented Jul 7, 2023 •
edited by pr-preview bot
Loading

OrKoN
OrKoN requested changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have double checked the spec and it does not look like we are able to change it. In case, if a command cannot be parsed or does not match any commands, the ID can be null.

@thiagowfx
Copy link
Member

NOTE: command id can be null, in which case the id field will also be set to null, not omitted from response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lightning00Blade @thiagowfx @OrKoN