New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update references to JavaScript primitives #483

Merged

jrandolf-2 merged 1 commit into master from jrandolf/references

Jul 10, 2023

Contributor

jrandolf-2 commented Jul 10, 2023 •

edited by pr-preview bot

Loading

Fixed: #455


          Update references to JavaScript primitives

jrandolf-2 requested review from jgraham and thiagowfx

July 10, 2023 11:57

thiagowfx approved these changes

View reviewed changes

jrandolf-2 merged commit cbc17e9 into master

3 checks passed

jrandolf-2 deleted the jrandolf/references branch

July 10, 2023 12:17

Member

jgraham commented Jul 10, 2023

This is wrong; it ends up linking to the Object wrapper types not the primitives. I'm going to revert.

jgraham mentioned this pull request

Revert "Update references to JavaScript primitives" #485

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet