Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec issue: Differentiate between List and Array #500

Merged
merged 6 commits into from
Jul 27, 2023

Conversation

lolaodelola
Copy link
Contributor

@lolaodelola lolaodelola commented Jul 19, 2023

This solution returns a list instead of an array so that it can be used later.


Preview | Diff

Copy link
Contributor

@jugglinmike jugglinmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For other reviewers, when the commit message explains that the list can be used later, it's referring to "deserialize key-value list"'s two call sites. Both call sites treat this algorithm's return value as a list.

.gitignore Outdated Show resolved Hide resolved
@lolaodelola
Copy link
Contributor Author

The deploy is failing with

  # Failed
  node -e 'require("@actions/core").setFailed("Failed. See details above.")'
  shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
  env:
    PNPM_HOME: /home/runner/setup-pnpm/node_modules/.bin
    PYTHONUSERBASE: /home/runner/work/_actions/w3c/spec-prod/v2/python_modules

I'm unsure where this error is coming from or what's causing it. When I build the HTML locally, I'm error free.

@lolaodelola lolaodelola marked this pull request as ready for review July 24, 2023 13:54
index.bs Outdated Show resolved Hide resolved
@jgraham jgraham merged commit a4cc71e into w3c:main Jul 27, 2023
3 checks passed
github-actions bot added a commit that referenced this pull request Jul 27, 2023
SHA: a4cc71e
Reason: push, by jgraham

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants