Rename |is root| to |include parent id| #726
Conversation
index.bs
Outdated
| @@ -2419,7 +2419,7 @@ To <dfn>get the browsing context info</dfn> given |context|, | |||
| 1. Let |context info| be a [=/map=] matching the | |||
| <code>browsingContext.Info</code> production with the <code>context</code> | |||
| field set to |context id|, the <code>parent</code> field set to |parent id| | |||
| if |is root| is <code>true</code>, or unset otherwise, the <code>url</code> | |||
| if |is root| is <code>false</code>, or unset otherwise, the <code>url</code> | |||
There was a problem hiding this comment.
why do we need |is root|? it |is root| being true the same as |parent id| being null?
There was a problem hiding this comment.
AFAIR we only want / have to include the parent id of a browsing context for the top-most browsing context that we want to get the browsing context info from. For frames we build up the tree and there is no need to have the extra parent id field.
Note that "is root" doesn't necessarily mean the top-level browsing context but rather the root browsing context from which we retrieve the browsing context information. Therefore, I don't see any issue with the current approach.
There was a problem hiding this comment.
ah, that clears this up then, thanks!
index.bs
Outdated
| @@ -2419,7 +2419,7 @@ To <dfn>get the browsing context info</dfn> given |context|, | |||
| 1. Let |context info| be a [=/map=] matching the | |||
| <code>browsingContext.Info</code> production with the <code>context</code> | |||
| field set to |context id|, the <code>parent</code> field set to |parent id| | |||
| if |is root| is <code>true</code>, or unset otherwise, the <code>url</code> | |||
| if |is root| is <code>false</code>, or unset otherwise, the <code>url</code> | |||
There was a problem hiding this comment.
AFAIR we only want / have to include the parent id of a browsing context for the top-most browsing context that we want to get the browsing context info from. For frames we build up the tree and there is no need to have the extra parent id field.
Note that "is root" doesn't necessarily mean the top-level browsing context but rather the root browsing context from which we retrieve the browsing context information. Therefore, I don't see any issue with the current approach.
SHA: a86a0c7 Reason: push, by OrKoN Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|is root| makes it look like it indicates whether the context is a root of the context tree (parent id === null) but it actually indicates whether the |parent id| needs to be included into the resulting info object.
Preview | Diff